Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move funcs of framework to common runtimeclass. #84411

Merged
merged 1 commit into from Oct 30, 2019
Merged

Move funcs of framework to common runtimeclass. #84411

merged 1 commit into from Oct 30, 2019

Conversation

jfbai
Copy link
Contributor

@jfbai jfbai commented Oct 27, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

ref: #84380

Move functions in framework.go to module common.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

/assigin @oomichi

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jfbai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2019
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 27, 2019
@hwdef
Copy link
Member

hwdef commented Oct 28, 2019

/ok-to-test
LGTM

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2019
@hwdef
Copy link
Member

hwdef commented Oct 28, 2019 •
edited

PreconfiguredRuntimeClassHandler is used in test/e2e/node/runtimeclass.go
Should it be processed?

@jfbai
Copy link
Contributor Author

jfbai commented Oct 28, 2019

PreconfiguredRuntimeClassHandler is used in test/e2e/node/runtimeclass.go
Should it be processed?

@hwdef Thanks a lot, my mistake, according to the slack discussion, I think it should not.

@oomichi oomichi mentioned this pull request Oct 28, 2019
Closed
21 tasks
@oomichi
Copy link
Member

oomichi commented Oct 28, 2019

GetLogToFileFunc() is not used at all, so at least we can remove the function.

@timothysc
Copy link
Member

/assign @alejandrox1

@jfbai jfbai force-pushed the move-funcs-of-framework-to-common branch from 8588532 to d8baedd Compare October 29, 2019 02:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
@jfbai
Copy link
Contributor Author

jfbai commented Oct 29, 2019

/retest

GetLogToFileFunc() is not used at all, so at least we can remove the function.

@oomichi I updated this PRs, and only unused function is removed.

@jfbai jfbai force-pushed the move-funcs-of-framework-to-common branch from d8baedd to 5862612 Compare October 29, 2019 03:44
@oomichi
Copy link
Member

oomichi commented Oct 29, 2019

The caller of GetLogToFileFunc() has been removed since ae0dde5
So LGTM

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfbai, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jfbai
Copy link
Contributor Author

jfbai commented Oct 30, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit d0d4572 into kubernetes:master Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly Awaiting requested review from pohly

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@oomichi oomichi

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jfbai @k8s-ci-robot @hwdef @oomichi @timothysc @fejta-bot @alejandrox1